[PATCH] D41659: Implementing missing trigonometric optimizations

ADIL ARUN DANGUI via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Jan 2 21:14:14 PST 2018

cs15btech11041 added a comment.

In https://reviews.llvm.org/D41659#965688, @asb wrote:

> As mentioned in llvm-dev, it looks like David Majnemer and Craig Topper might be appropriate reviewers for this patch (or can perhaps help to suggest other reviewers).

Hi, thanks for the comment. Thanks for adding appropriate reviewers for the patch.

> It looks like you've run clang-format on the entire lib/Transforms/InstCombine/InstructionCombining.cpp file. This makes it harder to review the changes you've made. Best practice is to only clang-format lines that you touch. I use the git-clang-format helper script for this, and it looks like clang-format-diff.py can help if you're using SVN:

As suggested, I have updated the diff file with clang format only on the section of code modified/inserted. Hopefully it is easier for the review. Thanks for the suggestion.

> https://github.com/llvm-mirror/clang/blob/master/tools/clang-format/git-clang-format
>  https://github.com/llvm-mirror/clang/blob/master/tools/clang-format/clang-format-diff.py



More information about the llvm-commits mailing list