[PATCH] D40811: Delete temp file if rename fails

[Rafael Avila de Espindola via llvm-commits]

James Henderson via Phabricator <reviews at reviews.llvm.org> writes:

> jhenderson accepted this revision.
> jhenderson added a comment.
> This revision is now accepted and ready to land.
>
> LGTM. I confirmed that it works for the case I saw with LLD too.
>
> Is there a particular reason why you're using icacls instead of chmod (available in the GnuWin32 tools) for the test? I'd say it's more familiar to most people, but I'm not bothered either way.

Can chmod on windows change the D and DC ACL entries?

Cheers,
Rafael