[PATCH] D40811: Delete temp file if rename fails

James Henderson via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Dec 5 02:23:22 PST 2017


jhenderson accepted this revision.
jhenderson added a comment.
This revision is now accepted and ready to land.

LGTM. I confirmed that it works for the case I saw with LLD too.

Is there a particular reason why you're using icacls instead of chmod (available in the GnuWin32 tools) for the test? I'd say it's more familiar to most people, but I'm not bothered either way.


https://reviews.llvm.org/D40811





More information about the llvm-commits mailing list