[PATCH] D40811: Delete temp file if rename fails

[James Henderson via llvm-commits]

I don't know if it does or not, but I'm not sure that it needs to:
rename_fd fails with a permission denied error on a file marked as
read-only by chmod on Windows, which is presumably sufficient for this
case, no?

On 5 December 2017 at 16:20, Rafael Avila de Espindola <
rafael.espindola at gmail.com> wrote:

> James Henderson via Phabricator <reviews at reviews.llvm.org> writes:
>
> > jhenderson accepted this revision.
> > jhenderson added a comment.
> > This revision is now accepted and ready to land.
> >
> > LGTM. I confirmed that it works for the case I saw with LLD too.
> >
> > Is there a particular reason why you're using icacls instead of chmod
> (available in the GnuWin32 tools) for the test? I'd say it's more familiar
> to most people, but I'm not bothered either way.
>
> Can chmod on windows change the D and DC ACL entries?
>
> Cheers,
> Rafael
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20171205/99e8ad03/attachment-0001.html>