[PATCH] D38453: [dwarfdump] Verify that unit type matches root DIE

Adrian Prantl via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Oct 6 10:52:14 PDT 2017


aprantl added inline comments.


================
Comment at: include/llvm/DebugInfo/DWARF/DWARFUnit.h:296
 
+  static bool isValidUnitTag(dwarf::Tag Tag) {
+    return Tag == dwarf::DW_TAG_compile_unit ||
----------------
Should we move these two into Dwarf.h as `isUnitTag` ?


Repository:
  rL LLVM

https://reviews.llvm.org/D38453





More information about the llvm-commits mailing list