[PATCH] D38453: [dwarfdump] Verify that unit type matches root DIE

[Adrian Prantl via Phabricator via llvm-commits]

aprantl accepted this revision.
aprantl added inline comments.
This revision is now accepted and ready to land.


================
Comment at: include/llvm/DebugInfo/DWARF/DWARFUnit.h:315
+    case dwarf::DW_UT_split_compile:
+    case dwarf::DW_UT_split_type:
+      return Tag == dwarf::DW_TAG_imported_unit;
----------------
JDevlieghere wrote:
> aprantl wrote:
> > Is that correct? I thought imported units are an orthogonal concept to split units. (But I may be wrong here)
> Nope, this is wrong. I made this assumption before checking the standard which in its example uses a regular compile_unit. I must haveuploaded the patch before fixing this. 
this seems right now, thanks.


Repository:
  rL LLVM

https://reviews.llvm.org/D38453