[PATCH] D38453: [dwarfdump] Verify that unit type matches root DIE

Jonas Devlieghere via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Oct 6 11:55:13 PDT 2017


JDevlieghere marked an inline comment as done.
JDevlieghere added inline comments.


================
Comment at: include/llvm/DebugInfo/DWARF/DWARFUnit.h:296
 
+  static bool isValidUnitTag(dwarf::Tag Tag) {
+    return Tag == dwarf::DW_TAG_compile_unit ||
----------------
aprantl wrote:
> Should we move these two into Dwarf.h as `isUnitTag` ?
Sure, sounds reasonable! 


Repository:
  rL LLVM

https://reviews.llvm.org/D38453





More information about the llvm-commits mailing list