[PATCH] D37753: [AMDGPU] implemented pal metadata

[Tim Renouf via Phabricator via llvm-commits]

tpr added inline comments.


================
Comment at: lib/Target/AMDGPU/AMDGPUPTNote.h:36
     NT_AMDGPU_HSA_EXTENSION = 6,
+    NT_AMDGPU_PAL_CODE_OBJECT_VERSION = 8,
+    NT_AMDGPU_PAL_METADATA = 9,
----------------
kzhuravl wrote:
> Can't we use ELFOSABI_AMDGPU_PAL and ELFABIVERSION_AMDGPU_PAL instead?
Oops, this is not used any more after internal discussion. I'll remove the define.


================
Comment at: lib/Target/AMDGPU/AMDGPUPTNote.h:37
+    NT_AMDGPU_PAL_CODE_OBJECT_VERSION = 8,
+    NT_AMDGPU_PAL_METADATA = 9,
     NT_AMDGPU_HSA_CODE_OBJECT_METADATA = 10,
----------------
kzhuravl wrote:
> Can you make it 11?
Why? This is already in use within AMD as 9; this change just adds it to LLVM.


https://reviews.llvm.org/D37753