[PATCH] D37753: [AMDGPU] implemented pal metadata

Konstantin Zhuravlyov via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Sep 26 15:31:29 PDT 2017


kzhuravl added inline comments.


================
Comment at: lib/Target/AMDGPU/AMDGPUPTNote.h:37
+    NT_AMDGPU_PAL_CODE_OBJECT_VERSION = 8,
+    NT_AMDGPU_PAL_METADATA = 9,
     NT_AMDGPU_HSA_CODE_OBJECT_METADATA = 10,
----------------
tpr wrote:
> kzhuravl wrote:
> > Can you make it 11?
> Why? This is already in use within AMD as 9; this change just adds it to LLVM.
Because 9 is reserved. See docs.


https://reviews.llvm.org/D37753





More information about the llvm-commits mailing list