[PATCH] D37753: [AMDGPU] implemented pal metadata

[Konstantin Zhuravlyov via Phabricator via llvm-commits]

kzhuravl added inline comments.


================
Comment at: lib/Target/AMDGPU/AMDGPUPTNote.h:36
     NT_AMDGPU_HSA_EXTENSION = 6,
+    NT_AMDGPU_PAL_CODE_OBJECT_VERSION = 8,
+    NT_AMDGPU_PAL_METADATA = 9,
----------------
Can't we use ELFOSABI_AMDGPU_PAL and ELFABIVERSION_AMDGPU_PAL instead?


================
Comment at: lib/Target/AMDGPU/AMDGPUPTNote.h:37
+    NT_AMDGPU_PAL_CODE_OBJECT_VERSION = 8,
+    NT_AMDGPU_PAL_METADATA = 9,
     NT_AMDGPU_HSA_CODE_OBJECT_METADATA = 10,
----------------
Can you make it 11?


https://reviews.llvm.org/D37753