[PATCH] D33638: [libcxx] Have separate abi library flags for static and shared builds
Martell Malone via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Tue Sep 12 15:44:30 PDT 2017
martell added inline comments.
================
Comment at: utils/merge_archives.py:121
- files = glob.glob(os.path.join(temp_directory_root, '*.o'))
if not files:
----------------
It seems this landed separately in rL313072 so I can remove this line.
Please ignore this line for the review
I don't think llvm-ar should output COFF objects as .obj just because they are COFF anyway.
It is a gnu style tool and should output all objects as .o
Repository:
rL LLVM
https://reviews.llvm.org/D33638
More information about the llvm-commits
mailing list