[PATCH] D33638: [libcxx] Have separate abi library flags for static and shared builds

[Martin Storsjö via Phabricator via llvm-commits]

mstorsjo added inline comments.


================
Comment at: utils/merge_archives.py:121
 
-    files = glob.glob(os.path.join(temp_directory_root, '*.o'))
     if not files:
----------------
martell wrote:
> It seems this landed separately in rL313072 so I can remove this line.
> Please ignore this line for the review
> 
> I don't think llvm-ar should output COFF objects as .obj just because they are COFF anyway.
> It is a gnu style tool and should output all objects as .o
> I don't think llvm-ar should output COFF objects as .obj just because they are COFF anyway.
> It is a gnu style tool and should output all objects as .o

It's not something that llvm-ar decides, but when creating the static library, the input files are named *.obj (which is something that cmake decides, whenever the target is windows, regardless of whether using gnu style or msvc style tools).


Repository:
  rL LLVM

https://reviews.llvm.org/D33638