[PATCH] D33638: [libcxx] Have separate abi library flags for static and shared builds

[Martell Malone via Phabricator via llvm-commits]

martell added a subscriber: compnerd.
martell added a comment.

Hey, @EricWF, @rnk would wither of you be in a position to do a review of this :)

In https://reviews.llvm.org/D33638#867665, @mstorsjo wrote:

> In https://reviews.llvm.org/D33638#867661, @mstorsjo wrote:
>
> > Hmm, maybe that's the same issue that I'm working around by passing `-flto-visibility-public-std`, which makes it skip the implicit dllimport for some implicitly defined C++ symbols.
>
>
> Sorry, that's actually `-Xclang -flto-visibility-public-std`. In current testing (without building libcxx as a DLL), I'm building calling code with these flags:
>
>   -fno-exceptions -D_LIBCXXABI_DISABLE_VISIBILITY_ANNOTATIONS -D_LIBCPP_DISABLE_VISIBILITY_ANNOTATIONS -Xclang -flto-visibility-public-std


Thanks for the update, this patch resolves the issue surrounding the objects having to be built separately for static and dll builds when trying to do both in the one cmake run.
Let's try and get this reviewed and merged first and then dig back into why we have issues with dll import and -flto-visibility-public-std.
We can create a new thread on the mailing list and ask @compnerd to weigh in on what he thinks is best to do about that.


Repository:
  rL LLVM

https://reviews.llvm.org/D33638