[PATCH] D37602: Properly hook debuginfo-tests up to lit and CMake

Zachary Turner via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Sep 7 16:52:04 PDT 2017


zturner added inline comments.


================
Comment at: debuginfo-tests/CMakeLists.txt:22
+  clang
+  lld
+  llvm-config
----------------
aprantl wrote:
> why does it need lld? Shouldn't the system linker be good enough?
No, lld is a hard requirement.  Part of what we're trying to do is test that we emit PDBs that can work with Microsoft tools.  If we use the system linker, that defeats the entire purpose.

As an aside, "system linker" on Windows isn't really a thing, since systems don't really //have// linkers unless you install them. Which in this case would be MSVC's linker, which we already know works for obvious reasons


https://reviews.llvm.org/D37602





More information about the llvm-commits mailing list