[PATCH] D37602: Properly hook debuginfo-tests up to lit and CMake

[Reid Kleckner via Phabricator via llvm-commits]

rnk added inline comments.


================
Comment at: debuginfo-tests/CMakeLists.txt:29
+
+add_lit_testsuite(check-debuginfo "Running debug info integration tests"
+  ${CMAKE_CURRENT_BINARY_DIR}
----------------
aprantl wrote:
> amccarth wrote:
> > I'm concerned that the difference between `ninja check-debuginfo` and `ninja check-llvm-debuginfo` isn't very obvious.  Can we tweak the name of this one, like `check-debuginfo-integration`?
> the target should be called check-clang-debuginfo. It is testing clang, not (or only indirectly) LLVM.
That's the first I've heard of check-llvm-debuginfo. It looks like @beanz added that in 2015. Personally I like `check-debuginfo` as is.


https://reviews.llvm.org/D37602