[PATCH] D37602: Properly hook debuginfo-tests up to lit and CMake

[Reid Kleckner via Phabricator via llvm-commits]

rnk added inline comments.


================
Comment at: debuginfo-tests/CMakeLists.txt:22
+  clang
+  lld
+  llvm-config
----------------
aprantl wrote:
> why does it need lld? Shouldn't the system linker be good enough?
Don't make this unconditional, do it like ASan does: add the dependency iff LLD is checked out. See how compiler-rt tests for it. We can feed lld's existence as a variable into the test suite. Besides, LLD doesn't have a functioning MachO port today. We need to disable any LLD-depending tests on Darwin.


================
Comment at: debuginfo-tests/lit.cfg:330
+    return set_of_features
+
+config.available_features.update(get_llvm_config_props())
----------------
This duplication sucks. We should install it in llvm's share directory next to its cmake or something, so that we can import it.


https://reviews.llvm.org/D37602