[PATCH] D37602: Properly hook debuginfo-tests up to lit and CMake

Adrian Prantl via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Sep 7 16:43:32 PDT 2017


aprantl added inline comments.


================
Comment at: debuginfo-tests/CMakeLists.txt:29
+
+add_lit_testsuite(check-debuginfo "Running debug info integration tests"
+  ${CMAKE_CURRENT_BINARY_DIR}
----------------
amccarth wrote:
> I'm concerned that the difference between `ninja check-debuginfo` and `ninja check-llvm-debuginfo` isn't very obvious.  Can we tweak the name of this one, like `check-debuginfo-integration`?
the target should be called check-clang-debuginfo. It is testing clang, not (or only indirectly) LLVM.


https://reviews.llvm.org/D37602





More information about the llvm-commits mailing list