[PATCH] D35569: [ARM] Remove FeatureNoARM implies ModeThumb.

Eric Christopher via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Aug 9 01:55:48 PDT 2017

echristo accepted this revision.
echristo added a comment.

In https://reviews.llvm.org/D35569#816289, @rengolin wrote:

> In https://reviews.llvm.org/D35569#816129, @fhahn wrote:
> > With FeatureARM, the generic CPU would have to have this feature, but when the features of the architecture (v6m) are applied, FeatureARM cannot be removed, so the behavior will be different to the current one (Architecture features are applied after CPU features I think). We could rename FeatureARM to FeatureThumbOnly, which is a bit clearer in my opinion.
> Correct. `FeatureNoARM` is specific to M-class. I don't mind how we call it as long as it's explicit the intention, and I think both `FeatureNoARM` and `FeatureThumbOnly` are clear.

Well, clear or not is a bit subjective ;)

That said, I think this is a strict improvement.



More information about the llvm-commits mailing list