[PATCH] D35569: [ARM] Remove FeatureNoARM implies ModeThumb.

Florian Hahn via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Aug 9 04:21:42 PDT 2017

fhahn added a comment.

In https://reviews.llvm.org/D35569#836330, @echristo wrote:

> In https://reviews.llvm.org/D35569#816289, @rengolin wrote:
> > Correct. `FeatureNoARM` is specific to M-class. I don't mind how we call it as long as it's explicit the intention, and I think both `FeatureNoARM` and `FeatureThumbOnly` are clear.
> Well, clear or not is a bit subjective ;)

Agreed, I think there's no need to change that.

> That said, I think this is a strict improvement.

Great, thanks for having another look. I'll commit the change soon soon.


More information about the llvm-commits mailing list