fhahn added a comment. I think this change should still go in (in combination with https://reviews.llvm.org/D35627) to get proper error messages in the attribute case. Please let me know if there are any more concerns. https://reviews.llvm.org/D35569