[PATCH] D34716: [AMDGPU] Add pseudo "old" and "wqm_mode" source to all DPP instructions

[Nicolai Hähnle via Phabricator via llvm-commits]

nhaehnle added a comment.

Some comments on what I noticed. Probably best if somebody else has a look as well.



================
Comment at: lib/Target/AMDGPU/VOP1Instructions.td:84-85
   let AsmVariantName     = ps.AsmVariantName;
   let Constraints        = ps.Constraints;
   let DisableEncoding    = ps.DisableEncoding;
   let TSFlags            = ps.TSFlags;
----------------
Duplicate setting of Constraints/DisableEncoding.


================
Comment at: lib/Target/AMDGPU/VOP2Instructions.td:105-106
   let AsmVariantName     = ps.AsmVariantName;
   let Constraints        = ps.Constraints;
   let DisableEncoding    = ps.DisableEncoding;
   let TSFlags            = ps.TSFlags;
----------------
Duplicate setting of Constraints/DisableEncoding.


================
Comment at: lib/Target/AMDGPU/VOPInstructions.td:451-452
   let UseNamedOperandTable = ps.UseNamedOperandTable;
   let Constraints          = ps.Constraints;
   let DisableEncoding      = ps.DisableEncoding;
   let TSFlags              = ps.TSFlags;
----------------
Both here and in VOP_SDWA_Real, it looks like there are duplicated pairs of let Constraints/DisableEncoding lines. One of those pairs should be removed.


https://reviews.llvm.org/D34716