[PATCH] D34716: [AMDGPU] Add pseudo "old" and "wqm_mode" source to all DPP instructions

[Connor Abbott via Phabricator via llvm-commits]

cwabbott added inline comments.


================
Comment at: lib/Target/AMDGPU/VOPInstructions.td:451-452
   let UseNamedOperandTable = ps.UseNamedOperandTable;
   let Constraints          = ps.Constraints;
   let DisableEncoding      = ps.DisableEncoding;
   let TSFlags              = ps.TSFlags;
----------------
nhaehnle wrote:
> Both here and in VOP_SDWA_Real, it looks like there are duplicated pairs of let Constraints/DisableEncoding lines. One of those pairs should be removed.
These duplicates already exist in master now, and removing them would be unrelated to the current change, so I thought I'd keep them for now -- I can make a separate change that removes them.


https://reviews.llvm.org/D34716