[PATCH] D34716: [AMDGPU] Add pseudo "old" and "wqm_mode" source to all DPP instructions

Connor Abbott via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Aug 3 17:48:36 PDT 2017


cwabbott updated this revision to Diff 109666.
cwabbott added a comment.

Fix assembling DPP instructions. Also, adopt a more conservative version of
https://reviews.llvm.org/D34715. In particular, we ignore Constraints/DisableEncoding from the original
instruction for the DPP version. The only instruction with any special
constraints is MAC, because of its fake third source, and there it doesn't make
sense to keep the fake third source since it has to be the same as the normal
"old" source anyways. We can revisit this if something else comes up, but I
think this is a good plan for now.


https://reviews.llvm.org/D34716

Files:
  lib/Target/AMDGPU/AsmParser/AMDGPUAsmParser.cpp
  lib/Target/AMDGPU/SIInstrInfo.td
  lib/Target/AMDGPU/VOP1Instructions.td
  lib/Target/AMDGPU/VOP2Instructions.td
  lib/Target/AMDGPU/VOPInstructions.td
  test/CodeGen/AMDGPU/inserted-wait-states.mir
  test/CodeGen/AMDGPU/llvm.amdgcn.mov.dpp.ll

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D34716.109666.patch
Type: text/x-patch
Size: 11534 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20170804/6e65220d/attachment-0001.bin>


More information about the llvm-commits mailing list