[PATCH] D35588: Remove --commit/--commit=1 flags/settings.

Matthias Braun via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Jul 18 16:37:46 PDT 2017


MatzeB created this revision.
Herald added a subscriber: mcrosier.

This removes the possibility to submit but not commit a run.

- Most users want to commit, and it was easy to forget the flag.
- If the intention is to check a submission for errors, `lnt checkformat` can be used.

This also reverts most of the changes in r308256; as there is little use
in making the flag simpler to use when we can just remove it instead.


Repository:
  rL LLVM

https://reviews.llvm.org/D35588

Files:
  docs/importing_data.rst
  docs/quickstart.rst
  lnt/lnttool/import_data.py
  lnt/lnttool/main.py
  lnt/lnttool/updatedb.py
  lnt/lnttool/viewcomparison.py
  lnt/server/db/testsuitedb.py
  lnt/server/ui/templates/submit_run.html
  lnt/server/ui/views.py
  lnt/tests/builtintest.py
  lnt/tests/compile.py
  lnt/tests/nt.py
  lnt/tests/test_suite.py
  lnt/util/ImportData.py
  lnt/util/ServerUtil.py
  tests/lnttool/PostgresDB.shtest
  tests/lnttool/UpdateDB.py
  tests/lnttool/submit.py
  tests/server/db/ImportProfile.py
  tests/server/db/ImportV4TestSuiteInstance.py
  tests/server/db/search.py
  tests/server/db/yamlschema.shtest
  tests/utils/blast.py

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D35588.107203.patch
Type: text/x-patch
Size: 34915 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20170718/c0176f29/attachment-0001.bin>


More information about the llvm-commits mailing list