[PATCH] D33872: [llvm-readobj] Accept -S as an alias for --sections

Petr Hosek via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Jul 18 16:36:04 PDT 2017


This revision was automatically updated to reflect the committed changes.
Closed by commit rL308392: [llvm-readobj] Accept -S as an alias for --sections (authored by phosek).

Changed prior to commit:
  https://reviews.llvm.org/D33872?vs=101334&id=107204#toc

Repository:
  rL LLVM

https://reviews.llvm.org/D33872

Files:
  llvm/trunk/test/tools/llvm-readobj/gnu-sections.test
  llvm/trunk/tools/llvm-readobj/llvm-readobj.cpp


Index: llvm/trunk/tools/llvm-readobj/llvm-readobj.cpp
===================================================================
--- llvm/trunk/tools/llvm-readobj/llvm-readobj.cpp
+++ llvm/trunk/tools/llvm-readobj/llvm-readobj.cpp
@@ -57,12 +57,16 @@
     cl::desc("Alias for --file-headers"),
     cl::aliasopt(FileHeaders));
 
-  // -sections, -s
+  // -sections, -s, -S
+  // Note: In GNU readelf, -s means --symbols!
   cl::opt<bool> Sections("sections",
     cl::desc("Display all sections."));
   cl::alias SectionsShort("s",
     cl::desc("Alias for --sections"),
     cl::aliasopt(Sections));
+  cl::alias SectionsShortUpper("S",
+    cl::desc("Alias for --sections"),
+    cl::aliasopt(Sections));
 
   // -section-relocations, -sr
   cl::opt<bool> SectionRelocations("section-relocations",
Index: llvm/trunk/test/tools/llvm-readobj/gnu-sections.test
===================================================================
--- llvm/trunk/test/tools/llvm-readobj/gnu-sections.test
+++ llvm/trunk/test/tools/llvm-readobj/gnu-sections.test
@@ -1,6 +1,6 @@
 RUN: llvm-readobj -s %p/Inputs/relocs.obj.elf-i386 --elf-output-style=GNU \
 RUN:   | FileCheck %s -check-prefix ELF32
-RUN: llvm-readobj -s %p/Inputs/relocs.obj.elf-x86_64 --elf-output-style=GNU \
+RUN: llvm-readobj -S %p/Inputs/relocs.obj.elf-x86_64 --elf-output-style=GNU \
 RUN:   | FileCheck %s -check-prefix ELF64
 
 ELF32:    Section Headers:


-------------- next part --------------
A non-text attachment was scrubbed...
Name: D33872.107204.patch
Type: text/x-patch
Size: 1402 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20170718/9b4fb265/attachment.bin>


More information about the llvm-commits mailing list