[PATCH] D35589: [LoopUnswitch][Dominators] Don't recompute DominatorTree

[Jakub Kuderski via Phabricator via llvm-commits]

kuhar created this revision.
Herald added a subscriber: mzolotukhin.

As of https://reviews.llvm.org/D35528 DominatorTree seems to be preserved correctly and there's no need to recompute it at the end of LoopUnswitch.

I tested this patch by calling `DT->verify()` instead of `DT->recompute()` -- I didn't find any failures when bootstrapping clang and building the llvm test suite.


https://reviews.llvm.org/D35589

Files:
  lib/Transforms/Scalar/LoopUnswitch.cpp


Index: lib/Transforms/Scalar/LoopUnswitch.cpp
===================================================================
--- lib/Transforms/Scalar/LoopUnswitch.cpp
+++ lib/Transforms/Scalar/LoopUnswitch.cpp
@@ -518,9 +518,6 @@
     Changed |= processCurrentLoop();
   } while(redoLoop);
 
-  // FIXME: Reconstruct dom info, because it is not preserved properly.
-  if (Changed)
-    DT->recalculate(*F);
   return Changed;
 }
 


-------------- next part --------------
A non-text attachment was scrubbed...
Name: D35589.107205.patch
Type: text/x-patch
Size: 421 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20170718/04a3e82a/attachment.bin>