[PATCH] D35236: Refactor gdb index creation

[Rui Ueyama via Phabricator via llvm-commits]

ruiu added inline comments.


================
Comment at: ELF/InputFiles.cpp:504
 
-  // If -gdb-index is given, LLD creates .gdb_index section, and that
-  // section serves the same purpose as .debug_gnu_pub{names,types} sections.
----------------
I think this is cleaner way of eliminating .debug_gnu_{pubnames,pubtypes} than doing it later. Is there any reason to move this code?


================
Comment at: ELF/SyntheticSections.h:506
 public:
-  GdbIndexSection();
+  GdbIndexSection(std::vector<GdbIndexChunk> Chunks);
   void finalizeContents() override;
----------------
Don't you want to add `&&`?


https://reviews.llvm.org/D35236