[PATCH] D35236: Refactor gdb index creation

[Rafael Avila de Espindola via llvm-commits]

Rui Ueyama via Phabricator <reviews at reviews.llvm.org> writes:

> ruiu added inline comments.
>
>
> ================
> Comment at: ELF/InputFiles.cpp:504
>  
> -  // If -gdb-index is given, LLD creates .gdb_index section, and that
> -  // section serves the same purpose as .debug_gnu_pub{names,types} sections.
> ----------------
> I think this is cleaner way of eliminating .debug_gnu_{pubnames,pubtypes} than doing it later. Is there any reason to move this code?

I will have to, but it doesn't have to be on this patch.

The reason is that once llvm delegates to lld, lld will use the
InputSection to fetch data.

Cheers,
Rafael