[PATCH] D35236: Refactor gdb index creation

[George Rimar via Phabricator via llvm-commits]

grimar added inline comments.


================
Comment at: ELF/GdbIndex.h:48
 struct GdbIndexChunk {
+  InputSection *Sec;
   std::vector<AddressEntry> AddressArea;
----------------
`DebugInfo`/`DebugInfoSec` may be ? `Sec` name has unclear meaning.


================
Comment at: ELF/SyntheticSections.cpp:1763
 
 static std::vector<InputSection *> getDebugInfoSections() {
   std::vector<InputSection *> Ret;
----------------
Since this method now not only returns .debug_info sections, but also
drops .debug_gnu_pub* sections, should it have different name may be ?


================
Comment at: ELF/SyntheticSections.cpp:1782
+  std::vector<InputSectionBase *> &V = InputSections;
+  V.erase(std::remove(V.begin(), V.end(), nullptr), V.end());
   return Ret;
----------------
Probably you can call 

```
Script->discard({S}}; 
```

for .debug_gnu_pub* sections instead of modifying InputSections.


https://reviews.llvm.org/D35236