[PATCH] D35063: [ConstHoisting] Turn on consthoist-with-block-frequency by default

[Wei Mi via Phabricator via llvm-commits]

wmi added inline comments.


================
Comment at: test/CodeGen/X86/fold-tied-op.ll:10
 ; CHECK:       addl {{.*#+}} 4-byte Folded Reload
+; CHECK:       orl  {{.*#+}} 4-byte Folded Reload
 ; CHECK:       xorl {{.*#+}} 4-byte Folded Reload
----------------
davidxl wrote:
> explain this change?
After BFI based const hoisting enabled, some const is not hoisted to func entry. This will change live range and affect scheduling for live range shrinking (https://reviews.llvm.org/D32563). 


================
Comment at: test/Transforms/ConstantHoisting/X86/ehpad.ll:4
 
-; FIXME: The catchpad doesn't even use the constant, so a better fix would be to
-; insert the bitcast in the catchpad block.
----------------
davidxl wrote:
> Why removing the comment?
The bitcast is used for const 9209618997431186100. Now the bitcast is inserted in catchpad block when consthoist-with-block-frequency is enabled so the FIXME can be removed.


Repository:
  rL LLVM

https://reviews.llvm.org/D35063