[PATCH] D35063: [ConstHoisting] Turn on consthoist-with-block-frequency by default

David Li via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Jul 6 09:53:06 PDT 2017


davidxl added inline comments.


================
Comment at: test/CodeGen/X86/fold-tied-op.ll:10
 ; CHECK:       addl {{.*#+}} 4-byte Folded Reload
+; CHECK:       orl  {{.*#+}} 4-byte Folded Reload
 ; CHECK:       xorl {{.*#+}} 4-byte Folded Reload
----------------
wmi wrote:
> davidxl wrote:
> > explain this change?
> After BFI based const hoisting enabled, some const is not hoisted to func entry. This will change live range and affect scheduling for live range shrinking (https://reviews.llvm.org/D32563). 
Can you add profile annotation so that the test behavior does not change?


Repository:
  rL LLVM

https://reviews.llvm.org/D35063





More information about the llvm-commits mailing list