[PATCH] D35063: [ConstHoisting] Turn on consthoist-with-block-frequency by default

David Li via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Jul 6 09:31:09 PDT 2017


davidxl added inline comments.


================
Comment at: test/CodeGen/X86/fold-tied-op.ll:10
 ; CHECK:       addl {{.*#+}} 4-byte Folded Reload
+; CHECK:       orl  {{.*#+}} 4-byte Folded Reload
 ; CHECK:       xorl {{.*#+}} 4-byte Folded Reload
----------------
explain this change?


================
Comment at: test/Transforms/ConstantHoisting/X86/ehpad.ll:4
 
-; FIXME: The catchpad doesn't even use the constant, so a better fix would be to
-; insert the bitcast in the catchpad block.
----------------
Why removing the comment?


Repository:
  rL LLVM

https://reviews.llvm.org/D35063





More information about the llvm-commits mailing list