[PATCH] D34525: Replace trivial use of external rc.exe by writing our own .res file.

Rui Ueyama via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Jun 22 14:51:37 PDT 2017


ruiu added a comment.

It indeed will require extra copy, but that is fine. You don't need to avoid extra copy here since the generated file image is small and this is executed just once.

You can use `push_back` or something to avoid `resize`, no? Or, you can use an OutputStream backed up by some buffer and write data using `operator<<` there.


https://reviews.llvm.org/D34525





More information about the llvm-commits mailing list