[PATCH] D34525: Replace trivial use of external rc.exe by writing our own .res file.

Eric Beckmann via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Jun 22 15:50:14 PDT 2017


ecbeckmann updated this revision to Diff 103654.
ecbeckmann marked 5 inline comments as done.
ecbeckmann added a comment.

Made some style changes.  Also fixed bug in magic test where the full .res magic number was not recognized.


https://reviews.llvm.org/D34525

Files:
  lld/COFF/DriverUtils.cpp
  llvm/include/llvm/BinaryFormat/COFF.h
  llvm/include/llvm/Object/WindowsResource.h
  llvm/lib/BinaryFormat/Magic.cpp
  llvm/lib/Object/WindowsResource.cpp
  llvm/unittests/BinaryFormat/TestFileMagic.cpp

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D34525.103654.patch
Type: text/x-patch
Size: 11204 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20170622/26e219e3/attachment.bin>


More information about the llvm-commits mailing list