[PATCH] D34525: Replace trivial use of external rc.exe by writing our own .res file.

[Eric Beckmann via Phabricator via llvm-commits]

ecbeckmann added a comment.

In https://reviews.llvm.org/D34525#788360, @ruiu wrote:

> I think a better way of creating manifest file contents is to construct a temporary std::vector and then copy it to a MemoryBuffer after you append everything to the vector. This way, you don't need to compute the size of the result ahead of time.


Hmmm won't this method require an extra copy?  Also, it seems less convenient and more messy to have all these resize() operations before we write anything.


https://reviews.llvm.org/D34525