[PATCH] D34340: [XRay] Reduce synthetic references emitted by XRay

[Dean Michael Berris via Phabricator via llvm-commits]

dberris added a comment.

Thanks -- landing this now, we can change more of the details later.



================
Comment at: lib/CodeGen/AsmPrinter/AsmPrinter.cpp:2833-2834
   OutStreamer->EmitLabel(IdxRef);
   OutStreamer->EmitSymbolValue(SledsStart, WordSizeBytes);
   OutStreamer->EmitSymbolValue(SledsEnd, WordSizeBytes);
   OutStreamer->SwitchSection(PrevSection);
----------------
dblaikie wrote:
> Do these both need to be link-time (or even runtime, I guess) relocations? Or could the 'end' be stored as "end - start" (ie: length rather than end) to remove an extra relocation from the object file?
We can change this, but then that means we're going to have to coordinate it between how we're using the index in the runtime and the back-end (here). Is the concern the effect on linking time? Or do these symbols pollute the debug info somehow?


https://reviews.llvm.org/D34340