[PATCH] D34340: [XRay] Reduce synthetic references emitted by XRay

David Blaikie via llvm-commits llvm-commits at lists.llvm.org
Wed Jun 21 00:17:17 PDT 2017


On Tue, Jun 20, 2017 at 11:16 PM Dean Michael Berris via Phabricator <
reviews at reviews.llvm.org> wrote:

> dberris added a comment.
>
> Thanks -- landing this now, we can change more of the details later.
>
>
>
> ================
> Comment at: lib/CodeGen/AsmPrinter/AsmPrinter.cpp:2833-2834
>    OutStreamer->EmitLabel(IdxRef);
>    OutStreamer->EmitSymbolValue(SledsStart, WordSizeBytes);
>    OutStreamer->EmitSymbolValue(SledsEnd, WordSizeBytes);
>    OutStreamer->SwitchSection(PrevSection);
> ----------------
> dblaikie wrote:
> > Do these both need to be link-time (or even runtime, I guess)
> relocations? Or could the 'end' be stored as "end - start" (ie: length
> rather than end) to remove an extra relocation from the object file?
> We can change this, but then that means we're going to have to coordinate
> it between how we're using the index in the runtime and the back-end
> (here). Is the concern the effect on linking time? Or do these symbols
> pollute the debug info somehow?
>

Just link time and object size - sounded like you were interested in object
size, so this seemed relevant.


>
>
> https://reviews.llvm.org/D34340
>
>
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20170621/b021c553/attachment.html>


More information about the llvm-commits mailing list