[PATCH] D34340: [XRay] Reduce synthetic references emitted by XRay

David Blaikie via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Jun 19 13:46:19 PDT 2017


dblaikie accepted this revision.
dblaikie added a comment.
This revision is now accepted and ready to land.

Roughly makes sense to me.



================
Comment at: lib/CodeGen/AsmPrinter/AsmPrinter.cpp:2833-2834
   OutStreamer->EmitLabel(IdxRef);
   OutStreamer->EmitSymbolValue(SledsStart, WordSizeBytes);
   OutStreamer->EmitSymbolValue(SledsEnd, WordSizeBytes);
   OutStreamer->SwitchSection(PrevSection);
----------------
Do these both need to be link-time (or even runtime, I guess) relocations? Or could the 'end' be stored as "end - start" (ie: length rather than end) to remove an extra relocation from the object file?


https://reviews.llvm.org/D34340





More information about the llvm-commits mailing list