[PATCH] D34432: [PDB] Add symbols to the PDB

Zachary Turner via llvm-commits llvm-commits at lists.llvm.org
Tue Jun 20 18:13:36 PDT 2017


Actually I'm working on that, but not for merging. I am working on an
every-symbol.test and every-type.test that systematically tests every
single type we know about
On Tue, Jun 20, 2017 at 6:12 PM Reid Kleckner via Phabricator <
reviews at reviews.llvm.org> wrote:

> rnk added a comment.
>
> In https://reviews.llvm.org/D34432#786170, @rnk wrote:
>
> > In https://reviews.llvm.org/D34432#786167, @zturner wrote:
> >
> > > Since we already merge type streams, can you write a test that
> verifies that these are re-written correctly after linking?  Right now the
> only symbols in the test output have simple type indices (e.g. `int`), it
> would be nice to see some symbols in there that refer to non-simple types
> that have moved around during the type merging process.
> >
> >
> > In theory the S_GPROC32_ID record should exercise that, but the minimal
> dumper doesn't print item ids. I can hack on that first, and then we don't
> need another test.
>
>
> Eh, who am I kidding. We should have a test that goes on and exercises as
> many symbol records as possible. I'll put that together.
>
>
> https://reviews.llvm.org/D34432
>
>
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20170621/6353d89b/attachment.html>


More information about the llvm-commits mailing list