[PATCH] D34432: [PDB] Add symbols to the PDB

Reid Kleckner via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Jun 20 18:12:26 PDT 2017


rnk added a comment.

In https://reviews.llvm.org/D34432#786170, @rnk wrote:

> In https://reviews.llvm.org/D34432#786167, @zturner wrote:
>
> > Since we already merge type streams, can you write a test that verifies that these are re-written correctly after linking?  Right now the only symbols in the test output have simple type indices (e.g. `int`), it would be nice to see some symbols in there that refer to non-simple types that have moved around during the type merging process.
>
>
> In theory the S_GPROC32_ID record should exercise that, but the minimal dumper doesn't print item ids. I can hack on that first, and then we don't need another test.


Eh, who am I kidding. We should have a test that goes on and exercises as many symbol records as possible. I'll put that together.


https://reviews.llvm.org/D34432





More information about the llvm-commits mailing list