[PATCH] D34423: Create TD nodes for ADDCARRY and SUBCARRY opcodes

[Matt Arsenault via Phabricator via llvm-commits]

arsenm added inline comments.


================
Comment at: include/llvm/Target/TargetSelectionDAG.td:161
+def SDTCarryOp : SDTypeProfile<2, 3, [      // addcarry, subcarry
+  SDTCisSameAs<0, 2>, SDTCisSameAs<0, 3>, SDTCisInt<0>, SDTCisVT<1, i1>, SDTCisVT<4, i1>
+]>;
----------------
rampitec wrote:
> arsenm wrote:
> > arsenm wrote:
> > > i1 is wrong here since it will presumably be legalized to the target's boolean contents at some point, which won't necessarily be i1.
> > They probably just need to be constrained to int and the same, there's no way to constrain to the TLI hook reported types
> Isn't bool always i1 regardless of its target representation?
No, this will be legalized to the target's boolean type. i1 isn't required to be legal for the target. i1 is only used before legalization


Repository:
  rL LLVM

https://reviews.llvm.org/D34423