[PATCH] D34423: Create TD nodes for ADDCARRY and SUBCARRY opcodes

[Stanislav Mekhanoshin via Phabricator via llvm-commits]

rampitec added inline comments.


================
Comment at: include/llvm/Target/TargetSelectionDAG.td:161
+def SDTCarryOp : SDTypeProfile<2, 3, [      // addcarry, subcarry
+  SDTCisSameAs<0, 2>, SDTCisSameAs<0, 3>, SDTCisInt<0>, SDTCisVT<1, i1>, SDTCisVT<4, i1>
+]>;
----------------
arsenm wrote:
> arsenm wrote:
> > i1 is wrong here since it will presumably be legalized to the target's boolean contents at some point, which won't necessarily be i1.
> They probably just need to be constrained to int and the same, there's no way to constrain to the TLI hook reported types
Isn't bool always i1 regardless of its target representation?


Repository:
  rL LLVM

https://reviews.llvm.org/D34423