[PATCH] D34366: [AMDGPU] Add infer address spaces pass before SROA

[Stanislav Mekhanoshin via Phabricator via llvm-commits]

rampitec added inline comments.


================
Comment at: test/CodeGen/AMDGPU/infer-addrpace-pipeline.ll:1
+; RUN: opt -mtriple=amdgcn--amdhsa -disable-output -disable-verify -debug-pass=Structure -O2 %s 2>&1 | FileCheck -check-prefix=GCN %s
+
----------------
arsenm wrote:
> arsenm wrote:
> > Why disable verify?
> I'm not sure if this requires asserts for the -debug-pass to work, but it might
None of existing tests -debug-pass=Structure have REQUIRES: asserts.


================
Comment at: test/CodeGen/AMDGPU/infer-addrpace-pipeline.ll:1
+; RUN: opt -mtriple=amdgcn--amdhsa -disable-output -disable-verify -debug-pass=Structure -O2 %s 2>&1 | FileCheck -check-prefix=GCN %s
+
----------------
rampitec wrote:
> arsenm wrote:
> > arsenm wrote:
> > > Why disable verify?
> > I'm not sure if this requires asserts for the -debug-pass to work, but it might
> None of existing tests -debug-pass=Structure have REQUIRES: asserts.
-disable-verify is here to not flood the output of pass structure. There is nothing to verify there anyway.


Repository:
  rL LLVM

https://reviews.llvm.org/D34366