[PATCH] D34127: Make obj2yaml and yaml2obj support .debug$S and .debug$T sections

[Zachary Turner via Phabricator via llvm-commits]

zturner added inline comments.


================
Comment at: llvm/trunk/lib/DebugInfo/CodeView/StringsAndChecksums.cpp:35
+  OwnedStrings = llvm::make_unique<DebugStringTableSubsectionRef>();
+  consumeError(OwnedStrings->initialize(SR.getRecordData()));
+  Strings = OwnedStrings.get();
----------------
rnk wrote:
> This should propagate the Error on failure, this is library code.
In that case can I just assert if it fails?  We've got a corrupt object file at that point.


Repository:
  rL LLVM

https://reviews.llvm.org/D34127