[PATCH] D34127: Make obj2yaml and yaml2obj support .debug$S and .debug$T sections
Reid Kleckner via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Thu Jun 15 14:52:40 PDT 2017
rnk added inline comments.
================
Comment at: llvm/trunk/lib/DebugInfo/CodeView/StringsAndChecksums.cpp:35
+ OwnedStrings = llvm::make_unique<DebugStringTableSubsectionRef>();
+ consumeError(OwnedStrings->initialize(SR.getRecordData()));
+ Strings = OwnedStrings.get();
----------------
This should propagate the Error on failure, this is library code.
================
Comment at: llvm/trunk/lib/DebugInfo/CodeView/StringsAndChecksums.cpp:46
+ OwnedChecksums = llvm::make_unique<DebugChecksumsSubsectionRef>();
+ consumeError(OwnedChecksums->initialize(FCR.getRecordData()));
+ Checksums = OwnedChecksums.get();
----------------
ditto
Repository:
rL LLVM
https://reviews.llvm.org/D34127
More information about the llvm-commits
mailing list