[PATCH] D34085: [PGO] Register promote profile counter updates
Eli Friedman via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Mon Jun 12 18:07:38 PDT 2017
efriedma added a comment.
Did you do an analysis of whether this produces the same counter values for single-threaded code?
It looks like the way you're doing hoisting doesn't interact correctly with loops that don't exit; if a call in a loop throws an exception, or calls exit(), the counter values will be off.
https://reviews.llvm.org/D34085
More information about the llvm-commits
mailing list