[PATCH] D33575: [llvm-ar] Make llvm-lib behave more like the MSVC archiver
Peter Collingbourne via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Fri May 26 13:51:03 PDT 2017
pcc added inline comments.
================
Comment at: llvm/include/llvm/Object/ArchiveWriter.h:41
writeArchive(StringRef ArcName, std::vector<NewArchiveMember> &NewMembers,
- bool WriteSymtab, object::Archive::Kind Kind, bool Deterministic,
- bool Thin, std::unique_ptr<MemoryBuffer> OldArchiveBuf = nullptr);
+ bool WriteSymtab, bool WriteObjPaths, object::Archive::Kind Kind,
+ bool Deterministic, bool Thin,
----------------
Would it be simpler to store the member name in `NewArchiveMember` and pass `WriteObjPaths` to `NewArchiveMember::getFile()`?
================
Comment at: llvm/lib/Object/ArchiveWriter.cpp:194
+printMemberHeader(raw_fd_ostream &Out, object::Archive::Kind Kind,
+ bool WriteObjPaths, StringRef Name,
const sys::TimePoint<std::chrono::seconds> &ModTime,
----------------
Looks like `WriteObjPaths` is unused in this function.
https://reviews.llvm.org/D33575
More information about the llvm-commits
mailing list