[PATCH] D33575: [llvm-ar] Make llvm-lib behave more like the MSVC archiver
Rafael Avila de Espindola via llvm-commits
llvm-commits at lists.llvm.org
Fri May 26 14:58:03 PDT 2017
Reid Kleckner via Phabricator via llvm-commits
<llvm-commits at lists.llvm.org> writes:
> Files:
> clang/lib/Basic/Targets.cpp
> clang/lib/Frontend/InitPreprocessor.cpp
Looks like some unrelated clang changes
> +std::vector<std::string>
> +computeMemberNames(ArrayRef<NewArchiveMember> NewMembers, StringRef ArcName,
> + bool WriteObjPaths, bool Thin) {
> + std::vector<std::string> Names;
> + for (const NewArchiveMember &M : NewMembers) {
> + if (M.IsNew) {
> + Names.push_back(computeMemberName(ArcName, M.Buf->getBufferIdentifier(),
> + WriteObjPaths, Thin));
> + } else {
> + Names.push_back(M.Buf->getBufferIdentifier());
> + }
Nit: drop the {}
Fine by me otherwise.
Thanks,
Rafael
More information about the llvm-commits
mailing list