[PATCH] D33575: [llvm-ar] Make llvm-lib behave more like the MSVC archiver

[Reid Kleckner via Phabricator via llvm-commits]

rnk added inline comments.


================
Comment at: llvm/include/llvm/Object/ArchiveWriter.h:41
 writeArchive(StringRef ArcName, std::vector<NewArchiveMember> &NewMembers,
-             bool WriteSymtab, object::Archive::Kind Kind, bool Deterministic,
-             bool Thin, std::unique_ptr<MemoryBuffer> OldArchiveBuf = nullptr);
+             bool WriteSymtab, bool WriteObjPaths, object::Archive::Kind Kind,
+             bool Deterministic, bool Thin,
----------------
pcc wrote:
> Would it be simpler to store the member name in `NewArchiveMember` and pass `WriteObjPaths` to `NewArchiveMember::getFile()`?
We'd still need to re-relativize that path for thin archives during writeArchive, though. I like the way the name computation logic is all in the same place with the current patch.


================
Comment at: llvm/lib/Object/ArchiveWriter.cpp:194
+printMemberHeader(raw_fd_ostream &Out, object::Archive::Kind Kind,
+                  bool WriteObjPaths, StringRef Name,
                   const sys::TimePoint<std::chrono::seconds> &ModTime,
----------------
pcc wrote:
> Looks like `WriteObjPaths` is unused in this function.
True, we can get rid of it now.


https://reviews.llvm.org/D33575