[PATCH] D30527: Replacing float with new class Fraction for LSR alternative way of resolving complex solution
Sanjoy Das via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Tue May 23 15:47:50 PDT 2017
sanjoy added a comment.
In https://reviews.llvm.org/D30527#762673, @evstupac wrote:
> As for tests, this change should not change anything. The behavior should be the same. (float are replaced with fixed point to avoid potential different results on different CPUs).
I think that's contradictory -- you're saying that this change must be NFC; but it will avoid potential different results on different CPUs?
In any case, by "test" I meant testing the `FixedPoint64` class itself.
Repository:
rL LLVM
https://reviews.llvm.org/D30527
More information about the llvm-commits
mailing list